sioconvpsのみを学習するconfigファイルを追加 #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myxyy
reviewed
Nov 12, 2024
| dim_out: 1 | ||
| num_stack: ${python.eval:"12 * 12"} # assuming image size is 144x144, patch size is 12x12. | ||
| forward_dynamics_hidden_projection: | ||
| _target_: ami.models.policy_value_common_net.LerpStackedHidden |
There was a problem hiding this comment.
LerpStackedHiddenはヘッド毎の正規化が入っています。
SioConvPSは正規化が必要なほど隠れ状態のノルムは大きくならないはずなので
正規化抜いたバージョンのLerpStackedHiddenを用意できますでしょうか？
myxyy
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
特に目立った性能向上はありませんでしたが、ヘッド数といったハイパーパラメータが削除されたのでこれからSioconvPSを用いていこうと思います。
変更内容
影響範囲
Submit前の確認項目
make runコマンドでローカルでテストしましたか?補足